Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): set correct typing for tsconfig/tsConfig #2377

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 18, 2021

Summary

  • Generate typing from https://json.schemastore.org/tsconfig in pre-build step and include the generated .d.ts into build asset
  • Use the generated .d.ts for tsconfig and tsConfig options

Closes #2368

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl linked an issue Feb 18, 2021 that may be closed by this pull request
@ahnpnl ahnpnl marked this pull request as ready for review February 18, 2021 18:24
@ahnpnl ahnpnl merged commit d4f6aff into 26.5.2 Feb 18, 2021
@ahnpnl ahnpnl deleted the fix-option-types branch February 18, 2021 18:25
disableSourceOfProjectReferenceRedirect?: boolean
disableSolutionSearching?: boolean
[k: string]: unknown
}
Copy link

@jimisaacs jimisaacs Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahnpnl This is unfortunate that ts-jest has to maintain this. I totally feel typescript package should export, and support a script API with these types.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make this manually, or did you pull from somewhere?

const path = require('path')

void (async () => {
const response = await fetch('https://json.schemastore.org/tsconfig')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimisaacs pull and manually modified.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool 👍

This was referenced Mar 8, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definition and runtime for tsconfig option does not agree
2 participants